feat(step-generation: move_labware python command #17641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17641 +/- ##
==========================================
+ Coverage 25.69% 25.76% +0.07%
==========================================
Files 2851 2851
Lines 219479 219659 +180
Branches 17972 18043 +71
==========================================
+ Hits 56385 56591 +206
+ Misses 163079 163053 -26
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ddcc4
reviewed
Mar 5, 2025
| }, | ||
| ]) | ||
| expect(getSuccessResult(result).python).toBe( | ||
| `protocol.move_labware(mockPythonName, A4, use_gripper=False)` |
There was a problem hiding this comment.
Is this correct? Does A4 need to be quoted?
There was a problem hiding this comment.
oops, yes. good catch!
| console.error('expected to find a python new location but could not') | ||
| } | ||
|
|
||
| const pythonUseGripper = useGripper ? 'True' : 'False' |
There was a problem hiding this comment.
The API says use_gripper defaults to False. Can we leave it out unless it's true?
ddcc4
reviewed
Mar 5, 2025
| }, | ||
| ]) | ||
| expect(getSuccessResult(result).python).toBe( | ||
| `protocol.move_labware(mockPythonName, ${OFF_DECK}, use_gripper=False)` |
There was a problem hiding this comment.
For the output, let's put in the computed value of OFF_DECK so I can see if the generated code is correct.
ddcc4
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-1104
Overview
This PR creates the python command for
move_labwareTest Plan and Hands on Testing
There is unit test coverage for each option, feel free to smoke test it as well though!
Options include:
Changelog
moveLabware.tsgetCutoutIdByAddressableAreatostep-generationutilsRisk assessment
low, behind ff