Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): python commands for disengage and engage magnet #17642

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 4, 2025

closes AUTH-1103

Overview

Wire up the python generation for disengageMagnet and engageMagnet that is used for the OT-2 magnetic modules

Test Plan and Hands on Testing

I added unit test coverage but smoke test as well 😄

Changelog

  • add python generation for disengage and engage magnet
  • add test coverage

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner March 4, 2025 13:41
@jerader jerader requested a review from ddcc4 March 4, 2025 13:41
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.68%. Comparing base (8a9bb57) to head (29a31af).
Report is 5 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17642      +/-   ##
==========================================
- Coverage   25.69%   25.68%   -0.01%     
==========================================
  Files        2850     2851       +1     
  Lines      219383   219463      +80     
  Branches    17970    17971       +1     
==========================================
+ Hits        56363    56369       +6     
- Misses     163005   163079      +74     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 18.94% <0.00%> (-0.01%) ⬇️
step-generation 4.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tion/src/commandCreators/atomic/disengageMagnet.ts 87.50% <100.00%> (+1.29%) ⬆️
...eration/src/commandCreators/atomic/engageMagnet.ts 87.87% <100.00%> (+1.21%) ⬆️

invariantContext.moduleEntities[moduleId]?.type === MAGNETIC_MODULE_TYPE,
`expected module ${moduleId} to be magdeck, got ${invariantContext.moduleEntities[moduleId]?.type}`
moduleEntities[moduleId]?.type === MAGNETIC_MODULE_TYPE,
`expected module ${moduleId} to be magdeck, got ${moduleEntities[moduleId]?.type}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, what's the difference between the magnetic block and the magnetic module?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the magnetic module emits commands for changing the height of the magnet against the wellPlate. so disengage is to lower the magnet and engage raises the magnet. magnetic blocks don't emit any commands and the plate is set on top of the magnet at all times. The ot-2 is the only robot that uses magnetic modules and that is because for the flex, you can move the plates on/off the magnetic block with the gripper.

@jerader jerader merged commit 6423013 into edge Mar 4, 2025
24 checks passed
@jerader jerader deleted the sg_mag-mod-python branch March 4, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants