Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer) add 8.4.3 announcement #17643

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 4, 2025

Overview

add 8.4.3 announcement

close AUTH-1481 and AUTH-1509

Test Plan and Hands on Testing

  1. click gear icon
  2. click Release notes

Changelog

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11, jerader and syao1226 March 4, 2025 15:57
@koji koji marked this pull request as ready for review March 4, 2025 15:58
@koji koji requested a review from a team as a code owner March 4, 2025 15:58
@koji koji removed the request for review from a team March 4, 2025 15:58
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 1.09890% with 90 lines in your changes missing coverage. Please review.

Project coverage is 18.62%. Comparing base (edbf200) to head (70da0eb).
Report is 2 commits behind head on chore_release-pd-8.4.3.

Files with missing lines Patch % Lines
.../src/organisms/AnnouncementModal/announcements.tsx 0.00% 90 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.4.3   #17643      +/-   ##
==========================================================
- Coverage                   18.63%   18.62%   -0.01%     
==========================================================
  Files                        2743     2743              
  Lines                      211625   211706      +81     
  Branches                     6533     6534       +1     
==========================================================
  Hits                        39439    39439              
- Misses                     172186   172267      +81     
Flag Coverage Δ
protocol-designer 18.62% <1.09%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...er/src/pages/ProtocolOverview/ProtocolMetadata.tsx 100.00% <100.00%> (ø)
.../src/organisms/AnnouncementModal/announcements.tsx 2.78% <0.00%> (-0.65%) ⬇️

@koji koji added the authorship label Mar 4, 2025
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments. should be good to merge after they are addressed and after the unit tests are passing

@koji koji merged commit 6150966 into chore_release-pd-8.4.3 Mar 4, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants