Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer) fix liquid exceeded error text key #17645

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 4, 2025

Overview

fix liquid exceeded error text key

Screenshot 2025-03-04 at 11 28 29 AM

close AUTH-1506

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji changed the base branch from edge to chore_release-pd-8.4.3 March 4, 2025 16:31
@koji koji requested review from ncdiehl11, jerader and syao1226 March 4, 2025 16:32
@koji koji marked this pull request as ready for review March 4, 2025 16:32
@koji koji requested a review from a team as a code owner March 4, 2025 16:32
@koji koji added the authorship label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.63%. Comparing base (edbf200) to head (58d75c8).
Report is 1 commits behind head on chore_release-pd-8.4.3.

Files with missing lines Patch % Lines
...src/organisms/AssignLiquidsModal/LiquidToolbox.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-8.4.3   #17645   +/-   ##
=======================================================
  Coverage                   18.63%   18.63%           
=======================================================
  Files                        2743     2743           
  Lines                      211625   211625           
  Branches                     6533     6534    +1     
=======================================================
  Hits                        39439    39439           
  Misses                     172186   172186           
Flag Coverage Δ
protocol-designer 18.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...src/organisms/AssignLiquidsModal/LiquidToolbox.tsx 0.52% <0.00%> (ø)

@koji koji removed the request for review from a team March 4, 2025 16:42
@koji koji merged commit 841c362 into chore_release-pd-8.4.3 Mar 4, 2025
15 of 17 checks passed
@koji koji deleted the fix_AUTH-1506 branch March 4, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants