feat(step-generation): plate reader python commands #17646
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17646 +/- ##
==========================================
+ Coverage 25.69% 25.89% +0.20%
==========================================
Files 2850 2851 +1
Lines 219383 220087 +704
Branches 17970 18220 +250
==========================================
+ Hits 56363 56998 +635
- Misses 163005 163074 +69
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| @@ -19,5 +24,8 @@ export const absorbanceReaderInitialize: CommandCreator< | |||
| }, | |||
| }, | |||
| ], | |||
| python: `${pythonName}.initialize(${formatPyStr( | |||
| measureMode | |||
| )}, [${sampleWavelengths}], ${referenceWavelengthPython})`, | |||
There was a problem hiding this comment.
sampleWavelengths is an array, right? Please use formatPyList() for formatting Python arrays instead of stringifying it yourself. (Your output is missing the space between numbers idiomatic Python would use.)
There was a problem hiding this comment.
oops, thanks! didn't realize i would need to use formatPyList() for that
| @@ -36,5 +40,6 @@ export const absorbanceReaderRead: CommandCreator< | |||
| }, | |||
| }, | |||
| ], | |||
| python: `${pythonName}.read(${pythonfileName})`, | |||
There was a problem hiding this comment.
Could you include the export_filename= argument name here, since the argument is optional?
| @@ -36,5 +40,6 @@ export const absorbanceReaderRead: CommandCreator< | |||
| }, | |||
| }, | |||
| ], | |||
| python: `${pythonName}.read(${pythonfileName})`, | |||
There was a problem hiding this comment.
Hm, is this the correct way to use the filename? According the docs, the argument is just a prefix, and the files will be saved under names like "my_data_450.csv". Is that the behavior we expect?
There was a problem hiding this comment.
yeah i think that's correct!
| @@ -19,5 +24,8 @@ export const absorbanceReaderInitialize: CommandCreator< | |||
| }, | |||
| }, | |||
| ], | |||
| python: `${pythonName}.initialize(${formatPyStr( | |||
| measureMode | |||
| )}, ${formatPyList(sampleWavelengths)}, ${referenceWavelengthPython})`, | |||
There was a problem hiding this comment.
Is referenceWavelengthPython optional? Would this produce code like
initialize("single", [123], )
if referenceWavelength is null?
There was a problem hiding this comment.
ya, good catch, i should have added a test case for this. addressing it now
closes AUTH-1512
Overview
this PR creates the python commands for the 4 plate reader commands: open lid, close lid, initialize, and read. For reading, the output is a CSV file and not imbedded in the python protocol, since PD only supports outputting into a CSV file right now.
Test Plan and Hands on Testing
Review the unit tests and smoke test!
Changelog
Risk assessment
low, behind ff