Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): plate reader python commands #17646

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 4, 2025

closes AUTH-1512

Overview

this PR creates the python commands for the 4 plate reader commands: open lid, close lid, initialize, and read. For reading, the output is a CSV file and not imbedded in the python protocol, since PD only supports outputting into a CSV file right now.

Test Plan and Hands on Testing

Review the unit tests and smoke test!

Changelog

  • add python command for the 4 plate reader commands
  • add unit test coverage

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner March 4, 2025 16:32
@jerader jerader requested review from ddcc4 and ncdiehl11 March 4, 2025 16:32
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 25.69%. Comparing base (8a9bb57) to head (b335d29).
Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...mmandCreators/atomic/absorbanceReaderInitialize.ts 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17646   +/-   ##
=======================================
  Coverage   25.69%   25.69%           
=======================================
  Files        2850     2851    +1     
  Lines      219383   219475   +92     
  Branches    17970    17975    +5     
=======================================
+ Hits        56363    56392   +29     
- Misses     163005   163068   +63     
  Partials       15       15           
Flag Coverage Δ
protocol-designer 18.94% <4.76%> (-0.01%) ⬇️
step-generation 4.39% <95.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...commandCreators/atomic/absorbanceReaderCloseLid.ts 100.00% <100.00%> (ø)
.../commandCreators/atomic/absorbanceReaderOpenLid.ts 100.00% <100.00%> (ø)
...src/commandCreators/atomic/absorbanceReaderRead.ts 80.55% <100.00%> (+2.43%) ⬆️
...mmandCreators/atomic/absorbanceReaderInitialize.ts 96.29% <88.88%> (-3.71%) ⬇️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant