feat(step-generation): python command generation for heater-shaker co… #17647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17647 +/- ##
=======================================
Coverage 25.68% 25.68%
=======================================
Files 2851 2851
Lines 219457 219473 +16
Branches 17971 17972 +1
=======================================
+ Hits 56363 56379 +16
Misses 163079 163079
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ddcc4
approved these changes
Mar 4, 2025
| @@ -128,6 +128,9 @@ describe('heaterShaker compound command creator', () => { | |||
| }, | |||
| }, | |||
| ]) | |||
| expect(getSuccessResult(result).python).toBe( | |||
| 'mock_heater_shaker_1.close_labware_latch()\nmock_heater_shaker_1.set_target_temperature(80)\nmock_heater_shaker_1.set_and_wait_for_shake_speed(444)\nprotocol.delay(seconds=30)\nmock_heater_shaker_1.deactivate_shaker()\nmock_heater_shaker_1.deactivate_heater()' | |||
| ) | |||
There was a problem hiding this comment.
Feel free to use a multiline string here to make this easier to read, like we do for other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mmands
closes AUTH-1102
Overview
This PR adds python support for the majority of heater-shaker commands +
setTemperaturesince it is used for heater-shaker (as well as temperature module commands)Test Plan and Hands on Testing
I added unit test coverage but also review the code and smoke test
Changelog
Risk assessment
low, behind ff