Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add fetch-depth: 0 to build-pd workflow #17649

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 4, 2025

closes AUTH-1513

Overview

Fix the version tag not working correctly.

@jerader jerader requested a review from a team as a code owner March 4, 2025 20:25
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.62%. Comparing base (841c362) to head (3666961).
Report is 2 commits behind head on chore_release-pd-8.4.3.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           chore_release-pd-8.4.3   #17649      +/-   ##
==========================================================
- Coverage                   18.63%   18.62%   -0.02%     
==========================================================
  Files                        2743     2743              
  Lines                      211625   211739     +114     
  Branches                     6534     6534              
==========================================================
  Hits                        39439    39439              
- Misses                     172186   172300     +114     
Flag Coverage Δ
protocol-designer 18.62% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jerader jerader requested review from koji and ncdiehl11 March 4, 2025 20:45
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this!

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@jerader jerader merged commit 624a265 into chore_release-pd-8.4.3 Mar 4, 2025
20 checks passed
@jerader jerader deleted the chore_fetch-depth branch March 4, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants