feat(step-generation): python commands for temperature module #17650
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17650 +/- ##
=======================================
Coverage 25.68% 25.68%
=======================================
Files 2851 2851
Lines 219457 219468 +11
Branches 17971 17973 +2
=======================================
+ Hits 56363 56371 +8
- Misses 163079 163082 +3
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| const moduleType = invariantContext.moduleEntities[moduleId]?.type | ||
| const module = invariantContext.moduleEntities[moduleId] | ||
| const moduleType = module?.type | ||
| const modulePythonName = module?.pythonName |
There was a problem hiding this comment.
Is there ever a case where module is undefined? Are you only doing the module? thing because the typechecker wants it?
There was a problem hiding this comment.
hmm actually, good question. i don't think we should hit this since we throw an error if it is null. i'll remove it
| @@ -83,6 +84,7 @@ export const waitForTemperature: CommandCreator<TemperatureParams> = ( | |||
| }, | |||
| ], | |||
| warnings: warnings.length > 0 ? warnings : undefined, | |||
| python: pythonCommand, | |||
There was a problem hiding this comment.
Stylistic question: Do people prefer to name the variable python so that you can just say:
{
...,
python,
}
There was a problem hiding this comment.
oh good call, i can change that!
| const moduleType = invariantContext.moduleEntities[moduleId]?.type | ||
| const module = invariantContext.moduleEntities[moduleId] | ||
| const moduleType = module?.type | ||
| const pythonCommand = `${module?.pythonName}.wait_for_temperature(${celsius})` |
There was a problem hiding this comment.
Hey, I'm having trouble finding the wait_for_temperature() function in the API that takes a temperature argument. Could you point me to where it is?
There was a problem hiding this comment.
ahh good question. i just looked in the api docs, and i don't see it either. i don't see the temperature module even emitting wait_for_temperature, i only see it referenced for a heater-shaker 🤔 let me double check with the backend team
closes AUTH-1100
Overview
This PR adds python command support for the temperature module (
deactivateandwaitForTemprature). NOTE:setTemperaturesupport is added hereTest Plan and Hands on Testing
Review code but there are unit tests. Also smoke test!
Changelog
Risk assessment
low, behind ff