Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add "lpc complete" redesigned view #17651

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 4, 2025

Closes EXEC-1130

Overview

Adds the highly anticipated "LPC Complete" view, which is updated as a part of the Redesign. As per tradition with every screen involving the success icon, the dimensions in Figma are not actually representative of the png, but that's ok.

Screenshot 2025-03-04 at 3 48 56 PM

This view isn't really accessible until #17627 merges, but this PR is not blocked by that one.

Test Plan and Hands on Testing

  • See pic.

Changelog

  • Added "LPC complete" screen.

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1, SyntaxColoring and a team March 4, 2025 20:57
@mjhuff mjhuff requested a review from a team as a code owner March 4, 2025 20:57
@mjhuff mjhuff requested review from TamarZanzouri and removed request for a team March 4, 2025 20:57
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last, LPC is complete

@mjhuff mjhuff merged commit 1bde7ac into edge Mar 6, 2025
30 checks passed
@mjhuff mjhuff deleted the app_add-lpc-complete-view branch March 6, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants