-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(shared-data): introduce linear interpolation helper #17652
Conversation
This PR introduces a linear interpolation helper to `shared-data` tobe used in liquid class implementation for continuous values in Protocol Designer and Quick Transfer. This will include all byVolume properties.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17652 +/- ##
==========================================
+ Coverage 25.68% 25.89% +0.21%
==========================================
Files 2851 2852 +1
Lines 219457 220137 +680
Branches 17971 18233 +262
==========================================
+ Hits 56363 57004 +641
- Misses 163079 163118 +39
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Overview
This PR introduces a linear interpolation helper to
shared-data
tobe used in liquid class implementation for continuous values in Protocol Designer and Quick Transfer. This will include all byVolume properties.Test Plan and Hands on Testing
Changelog
linearInterpolate
JS helper and testsReview requests
see test plan
Risk assessment
low. not wired up anywhere yet