Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): introduce linear interpolation helper #17652

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR introduces a linear interpolation helper to shared-data tobe used in liquid class implementation for continuous values in Protocol Designer and Quick Transfer. This will include all byVolume properties.

Test Plan and Hands on Testing

  • review logic and test code

Changelog

  • create linearInterpolate JS helper and tests

Review requests

see test plan

Risk assessment

low. not wired up anywhere yet

This PR introduces a linear interpolation helper to `shared-data` tobe used in liquid class implementation for continuous values in Protocol Designer and Quick Transfer. This will include all byVolume properties.
@ncdiehl11 ncdiehl11 self-assigned this Mar 4, 2025
@ncdiehl11 ncdiehl11 requested review from koji and syao1226 March 4, 2025 22:23
@ncdiehl11 ncdiehl11 marked this pull request as ready for review March 4, 2025 22:23
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner March 4, 2025 22:23
@ncdiehl11 ncdiehl11 changed the title feat(shared-data): introduce interpolation helper feat(shared-data): introduce linear interpolation helper Mar 4, 2025
@ncdiehl11 ncdiehl11 requested a review from jerader March 4, 2025 22:28
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 2.17391% with 45 lines in your changes missing coverage. Please review.

Project coverage is 25.89%. Comparing base (507da17) to head (a06defe).
Report is 15 commits behind head on edge.

Files with missing lines Patch % Lines
shared-data/js/helpers/linearInterpolate.ts 2.17% 45 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17652      +/-   ##
==========================================
+ Coverage   25.68%   25.89%   +0.21%     
==========================================
  Files        2851     2852       +1     
  Lines      219457   220137     +680     
  Branches    17971    18233     +262     
==========================================
+ Hits        56363    57004     +641     
- Misses     163079   163118      +39     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 19.09% <2.17%> (+0.15%) ⬆️
step-generation 4.59% <2.17%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/js/helpers/index.ts 61.06% <ø> (+5.74%) ⬆️
shared-data/js/helpers/linearInterpolate.ts 2.17% <2.17%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 requested a review from koji March 5, 2025 18:14
@ncdiehl11 ncdiehl11 requested a review from koji March 5, 2025 23:25
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit ecb3fef into edge Mar 6, 2025
51 of 52 checks passed
@ncdiehl11 ncdiehl11 deleted the sd_feat-inerpolate branch March 6, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants