Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use input instead of env to receive GitHub token #103

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

Awayume
Copy link
Contributor

@Awayume Awayume commented Oct 9, 2023

The GitHub token is automatically applied to input as a default value.
This eliminates the need to explicitly specify a token when using action.

@Platane
Copy link
Owner

Platane commented Oct 10, 2023

oooh that's good

I don't have time to review right now but will do this week

Copy link

@benzlokzik benzlokzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow that's so good

@Platane
Copy link
Owner

Platane commented Oct 17, 2023

hi, sorry it took me that long to reply.

I tested on a different PR and confirm it works :D

just two things:

I that's ok with you, I can merge #104 which reflects that

or yours if you want to edit

@Awayume
Copy link
Contributor Author

Awayume commented Oct 17, 2023

Thank you for the review.
I will edit my code to reflect it.

@Awayume Awayume force-pushed the main branch 3 times, most recently from a00ba00 to cab0e18 Compare October 17, 2023 11:44
Co-authored-by: Platane <me@platane.me>
@Platane Platane merged commit c9644d3 into Platane:main Oct 17, 2023
@Platane
Copy link
Owner

Platane commented Oct 17, 2023

thanks you @Awayume !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants