Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📓 remove inconsistent whitespace #73

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

tempewda
Copy link
Contributor

@tempewda tempewda commented Jul 3, 2023

this PR fixes #72

the cause seems to be the whitespaces between the inverted commas and the URL in srcset attribute of picture element, so i removed them

<picture>
  <source
    media="(prefers-color-scheme: dark)"
    srcset="
      https://raw.githubusercontent.com/platane/snk/output/github-contribution-grid-snake-dark.svg
    "
  />
  <source
    media="(prefers-color-scheme: light)"
    srcset="
      https://raw.githubusercontent.com/platane/snk/output/github-contribution-grid-snake.svg
    "
  />

there is an inconsistency in the whitespace surrounding the URL within the `srcset` attribute, hence we always get the snake in light mode
@tempewda tempewda changed the title 📝 remove inconsistent whitespace in srcset attribute of picture element 📝 remove inconsistent whitespace Jul 3, 2023
@tempewda tempewda changed the title 📝 remove inconsistent whitespace 📓 remove inconsistent whitespace Jul 3, 2023
@Platane
Copy link
Owner

Platane commented Jul 3, 2023

oh indeed thanks !

@Platane Platane merged commit 3eed9ce into Platane:main Jul 3, 2023
@tempewda tempewda deleted the doc/snake-dark-theme branch July 4, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snake is always in light mode in README
2 participants