-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Action failed with "Cannot read properties of undefined (reading 'split')" #77
Conversation
Appears to be working as expected (ref: my profile), should be good to merge. |
@aelassas , yup, it's working 🕺👍👍👍My action run: https://github.com/milaabl/milaabl-readme/actions/runs/5566208391 |
It's working My README ! Thank you for your help 👍 :) |
修复无法生成图片bug @see Platane/snk#77
Thanks for looking into that As @Zxilly pointed in #75 (comment), it will be safer to use the proper github api rather than parsing the dom (which will be subject to change again in the future) I will push a fix today 👍 Good job on the patch though ( and on deciphering the release steps :D ) |
Now, GitHub client returns the user's contributions as an HTML table, instead of a generated svg. The source code was updated to fix this issue.
snk/svg-only
action was updated too.Here is the working fork: https://github.com/aelassas/snk
You can test it with the following action: