Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable save-always for cache #164

Closed
wants to merge 2 commits into from
Closed

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jan 17, 2024

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43d73b0) 100.00% compared to head (3a2b4cb) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #164   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       231       231           
===========================================
  Files             33        33           
  Lines           3611      3611           
===========================================
  Hits            3611      3611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szepeviktor
Copy link
Contributor Author

Could close #158 ?

@szepeviktor
Copy link
Contributor Author

@PrinsFrank Released.

@szepeviktor szepeviktor marked this pull request as ready for review January 18, 2024 21:41
@PrinsFrank
Copy link
Owner

I opened a PR to implement the remaining forceOverwrite option actions/cache#1308. Let's wait for that to get merged and then this can be merged as well!

@PrinsFrank PrinsFrank marked this pull request as draft January 22, 2024 18:04
@PrinsFrank
Copy link
Owner

As I've moved all the CI for my personal repos to https://github.com/PrinsFrank/CI-PHP I'll close this PR here. Let's wait for the remaining PR on the actions-cache to be merged and then we can implement this change over in the CI-PHP repo. Thanks again!

@PrinsFrank PrinsFrank closed this Feb 3, 2024
@szepeviktor szepeviktor deleted the patch-3 branch February 3, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants