Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 1202 bump to minimum NodeJS 20.x version of 20.18.3 #1416

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 10, 2025

Related Issue

#1202

Documentation

N / A

Summary of Changes

  1. Node 20.18.3 was released which marks JSON Import Attributes as stable (we use JSON modules in walker-package-ranger.js)

    [030f155986] - esm: mark import attributes and JSON module as stable (Nicolò Ribaudo) #55333

  2. Bump minimum Node version in .nvmrc and netlify.toml
  3. Fix Node versions badge link in README.md

Note: this overlaps with actions/runner-images#1401 , but made it its own PR since it touches a different version range, and is also a breaking change

TODO

  1. Looks like we need to wait for GitHub Actions to catch up?
    error @greenwood/cli@0.31.0: The engine "node" is incompatible with this module. Expected version "^18.20.5 || ^20.18.3 || ^22.12.0". Got "20.18.2"
    error Found incompatible module.

@thescientist13 thescientist13 added this to the 1.0 milestone Feb 10, 2025
@thescientist13 thescientist13 self-assigned this Feb 10, 2025
@thescientist13 thescientist13 changed the title bump to minimum NodeJS 20.x version of 20.18.3 enhancement/issue 1202 bump to minimum NodeJS 20.x version of 20.18.3 Feb 10, 2025
@thescientist13 thescientist13 linked an issue Mar 1, 2025 that may be closed by this pull request
@thescientist13 thescientist13 mentioned this pull request Mar 1, 2025
34 tasks
@thescientist13 thescientist13 force-pushed the enhancement/issue-1202-bump-minimum-nodejs-20.x-version branch from c1c5a94 to a82555d Compare March 1, 2025 20:18
@thescientist13 thescientist13 merged commit a4d5e9f into master Mar 1, 2025
10 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-1202-bump-minimum-nodejs-20.x-version branch March 1, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Upgrade to latest Node LTS(s)
1 participant