Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eslint in GitHub Actions #266

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Use eslint in GitHub Actions #266

merged 5 commits into from
Mar 31, 2020

Conversation

renkun-ken
Copy link
Member

@Ikuyadeu
Copy link
Member

@renkun-ken Thank you for your early works.

I afraid about https://github.com/stefanoeb/eslint-action is not updating.

I https://github.com/actions/setup-node is made by the verified creator, and actions/setup-node#96 looks good to implementing that function

@renkun-ken
Copy link
Member Author

I was a bit confused by too many projects implementing eslint for GitHub Actions.

I'll switch to the setup-node version.

@Ikuyadeu Ikuyadeu added the engineering Maintenance, style, development process label Mar 30, 2020
@Ikuyadeu
Copy link
Member

@renkun-ken Great jobs!

@Ikuyadeu Ikuyadeu merged commit 3119fc0 into REditorSupport:master Mar 31, 2020
@Ikuyadeu Ikuyadeu mentioned this pull request Mar 31, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
engineering Maintenance, style, development process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renkun-ken @Ikuyadeu