Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a demo of <picture> #7

Closed
marcoscaceres opened this issue Oct 23, 2012 · 18 comments
Closed

Create a demo of <picture> #7

marcoscaceres opened this issue Oct 23, 2012 · 18 comments
Assignees

Comments

@marcoscaceres
Copy link
Contributor

It would be nice to present running in Webkit at the W3C TPAC meeting.

@Wilto
Copy link
Member

Wilto commented Oct 23, 2012

Native, you mean? I can whip up an example page using the markup and polyfill, if need be.

@ghost ghost assigned yoavweiss Oct 23, 2012
@marcoscaceres
Copy link
Contributor Author

@Wilto that would be great. And yep, native.

@yoavweiss
Copy link
Member

I'm working on the native part. Hopefully, I'd have more to show in a week.
I have an extremely basic demo page at http://yoavweiss.github.com/RespImg-WebCore/ but something fancier would be nice.

@yoavweiss
Copy link
Member

Got <picture><source src></picture> working! Next step is getting MQs to work like they should (both in PreloadScanner and in choosing the right source to display)

@yoavweiss
Copy link
Member

@marcoscaceres
Copy link
Contributor Author

Awesomeness! trying it out!

@attiks
Copy link
Member

attiks commented Oct 24, 2012

I tried as well, but I get
./chrome_release: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by ./chrome_release) ./chrome_release: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: versionGLIBCXX_3.4.15' not found (required by ./chrome_release)

@anselmh
Copy link
Member

anselmh commented Oct 24, 2012

This Chromium build does not work for me. I tested it with the following test-page (which is build after the draft from 17th Oct 12): http://tests.anselm-hannemann.com/w3c.respimg/chromium/

It seems that this does not recognize media-queries.

@marcoscaceres
Copy link
Contributor Author

@anselmh yes, media queries are not supported yet. Baby steps :)

@yoavweiss
Copy link
Member

@attiks - uploaded a release version (rather than a stripped debug version). Can you try it?

@attiks
Copy link
Member

attiks commented Oct 24, 2012

Nope, but don't waste to much time on this, might be my machine

./chrome: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.14' not found (required by ./chrome) ./chrome: /lib/x86_64-linux-gnu/libc.so.6: versionGLIBC_2.15' not found (required by ./chrome)
./chrome: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.15' not found (required by ./chrome)

@nwtn
Copy link

nwtn commented Oct 24, 2012

@yoavweiss Awesome job, the OS X version is working beautifully for me. It does, however, load src from both and . Is this by design? (I think I saw this came up on IRC, but I either forget or missed the end result.)

@marcoscaceres
Copy link
Contributor Author

@nwtn we are still not sure on that one. There are advantages and disadvantages.

@yoavweiss
Copy link
Member

@nwtn IMO, the way it's currently implemented (i.e. download src attr even though source is the one displayed) is a bug. (see yoavweiss/RespImg-WebCore#1).
What @marcoscaceres was referring to is that there may be cases where we want the src attr to be displayed (for example, if there are no matching source tags).
Anyway, I plan to fix it for now, and maybe implement src attr fetching only in the cases it is necessary later.

@marcoscaceres
Copy link
Contributor Author

@yoavweiss IMO, it should work exactly the same as audio and video.

@yoavweiss
Copy link
Member

@marcoscaceres no objections here, but let's take this issue to the spec's repo - ResponsiveImagesCG/picture-element#2

@yoavweiss
Copy link
Member

<picture src> issues are fixed in: yoavweiss/RespImg-WebCore@91aa93d

@marcoscaceres
Copy link
Contributor Author

@yoavweiss Chromium build worked perfectly during TPAC :) Again awesome work!

I'm preparing the video now and will record a video showing how it works based on the presentation we gave at tpac. See issue 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants