Use proper exception types in task #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit1rrr
reviewed
Jun 30, 2019
In reference to PR comment ReviewNB#9 (comment) this fixes following shortcomings: * Linting violation for overly broad exception * Additional whitespace before starting the traceback * Showing treon's traceback despite that only the traceback within the cell is relevant
f4lco
force-pushed
the
bugfix/broad-exception
branch
from
4b11822 to
41317cd
Compare
|
Looks good, merged! Thanks @f4lco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to PR #9 (comment) this fixes following shortcomings:
traceback within the cell is relevant