Add basic tests for notebook (test) execution (#7) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/ReviewNB/treon/pull/11 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
amit1rrr
reviewed
Jul 2, 2019
|
Thank you so much @f4lco. Looks great, tried it out locally and works as expected. Just left a few minor comments. |
|
You're welcome, @amit1rrr . Glad it works so well 👍 |
f4lco
force-pushed
the
feature/basic-tests
branch
from
37e5032 to
6873fd6
Compare
|
Merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add four basic test cases which verify that the notebook contents (and tests, respectively) indeed get executed.