Set working directory to the folder containing the notebook (fixes #12) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/ReviewNB/treon/pull/14 You'll be able to see notebook diffs and discuss changes. Powered by ReviewNB. |
|
Looks good @f4lco Thanks for adding in the test :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #12, and this comment, treon should have the same behavior as Jupyter, and use the notebooks' folder as working directory. This fixes priorly broken notebook-relative Python imports, and notebooks trying to read resources / data using notebook-relative file paths, in case the working directory of invoking treon did not match the directory containing the notebook.