-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to exclude files from testing #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@midokura-silvia Thank you for your contribution. I really like this simple approach to exclude files. I have made some suggestions to make it more robust. If we can work through those I'd be happy to merge it.
Whenever ready, please add some tests to make sure everything is working as intended and future regressions are caught beforehand. You can refer to the existing tests - https://github.com/ReviewNB/treon/tree/master/tests
Thank you for making the changes & putting in the tests. I tested with your branch & works as expected. I just have a few nitpicks after which we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one small linting error that is why travis ci is failing. You can run make lint
to see it. Once fixed good to merge.
d378750
to
45c4d72
Compare
Merged! @midokura-silvia Thank you for your contribution! |
@midokura-silvia Released this change in |
As described in #1, there is currently no way to exclude files from testing.
This pull request implements a simple way of excluding files from the command line via substring matching.