-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option --html to convert failed notebooks to html. #22
Open
bilke
wants to merge
1
commit into
ReviewNB:master
Choose a base branch
from
bilke:html-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
""" | ||
Usage: | ||
treon | ||
treon [PATH] [--threads=<number>] [-v] [--exclude=<string>]... | ||
treon [PATH] [--threads=<number>] [--html] [-v] [--exclude=<string>]... | ||
|
||
Arguments: | ||
PATH File or directory path to find notebooks to test. Searches recursively for directory paths. [default: current working directory] | ||
|
@@ -13,6 +13,7 @@ | |
absolute path starts with the specified string are excluded from testing. This option can be | ||
specified more than once to exclude multiple files or directories. If the exclude path is | ||
a valid directory name, only this directory is excluded. | ||
--html Write executed notebook to html | ||
-v --verbose Print detailed output for debugging. | ||
-h --help Show this screen. | ||
--version Show version. | ||
|
@@ -46,8 +47,9 @@ def main(): | |
setup_logging(arguments) | ||
LOG.info('Executing treon version %s', __version__) | ||
thread_count = arguments['--threads'] or DEFAULT_THREAD_COUNT | ||
html_output = arguments['--html'] or False | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe convert to Let's use |
||
notebooks = get_notebooks_to_test(arguments) | ||
tasks = [Task(notebook) for notebook in notebooks] | ||
tasks = [Task(notebook, html_output) for notebook in notebooks] | ||
print_test_collection(notebooks) | ||
trigger_tasks(tasks, thread_count) | ||
has_failed = print_test_result(tasks) | ||
|
@@ -65,7 +67,6 @@ def loglevel(arguments): | |
verbose = arguments['--verbose'] | ||
return logging.DEBUG if verbose else logging.INFO | ||
|
||
|
||
def trigger_tasks(tasks, thread_count): | ||
pool = ThreadPool(int(thread_count)) | ||
pool.map(Task.run_tests, tasks) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like html will only be generated if there's execution error. If there's an HTML flag then I'm guessing user is expecting HTML output even if the notebook executed successfully.