-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable cell number print when verbose logging activates #26
base: master
Are you sure you want to change the base?
Conversation
@eaidova Thank you for contributing to treon.
I agree that this is useful. In addition to cell index, it would be better to log the cell content as well. E.g. if a user sees that cell #67 failed, there's no easy way (that I know of) in JupyterLab UI to go to cell #67. The user will have to manually start counting from the top. If they also see the cell content then they can |
@amit1rrr I think your sggestion maybe too noisy... in case, if error happens there is stack trace with exact stacktrace including cell content. The problematic part for debugging is kernel died (that raised outside notebook and does not have any logging in some cases), so it will required to print every cell... |
Can you please share an example notebook where this happens? |
I was not able reproduce issue locally, only on ci machine, my treon logs looks like:
|
Thanks for sharing these. Just FYI - I'm out of office for a week. I will review this as soon as I'm back. |
add info about which cell executed in verbose logs, in some cases this info helpful for search source of Kernel Died error which does not have a lot of logs...