-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement quiet mode with reduced console output (fixes #4) #6
Conversation
@f4lco Thank you for your contribution. Couple of suggestions,
|
@amit1rrr I understand. I do like the suggested behavior you just laid out, but I do not think that is how a "quiet" mode supposedly works. I suggest the following: without arguments, show a minimum about of which notebooks are run, and the result table (compare with |
I like this. Those two things you mentioned and stack trace in case of failures is a good default. So default output would look something like,
Sure. It would have all the output from the default prepended with some more details like below,
--verbose seems a bit superfluous now but if we setup the logging levels as you have done we can add more useful outputs in future that would help with debugging the failures or even treon issues itself. What do you think? @sgugger I remember you requesting this feature at one point. I hope this proposal works for you. Feel free to chime in if you have any comments. |
This proposal seems great and perfectly in line with what I had suggested at one point! |
0cc4673
to
1809a8a
Compare
@amit1rrr finally, seems like we are on the same page now 🙂 I updated the PR accordingly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Couple of minor suggestions.
1809a8a
to
8d8d91c
Compare
Thanks for the contribution @f4lco. I have merged in the changes. Will update the package on PyPI in some time. |
Thank you very much for your time and patience, @amit1rrr ! Don't worry, it's not urgent 😉 |
Hello there 👋
I'm interested in a quiet mode and make a proposal using the stock
logging
module. The output format stays the same, in addition to the following behaviors:-q
eliminates all informational output, but keeps displaying all errors / test failures.-qq
is dedicated to heavily automated environments, which only rely on the exit code of treon.