Lint Treon + Travis #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amit1rrr
reviewed
Jun 28, 2019
amit1rrr
reviewed
Jun 28, 2019
amit1rrr
reviewed
Jun 28, 2019
|
Thanks! Just left some minor comments. Also flicked the switch on Travis CI. |
f4lco
force-pushed
the
feature/lint
branch
2 times, most recently
from
2e7a5bb to
d03640e
Compare
|
Thank god the builds were green 😄 And the badge appears to be working for this branch at least: |
|
Nice, it rarely builds successfully the first time 🙃 Merged. |
f4lco
added a commit
to f4lco/treon
that referenced
this pull request
Jun 28, 2019
In reference to PR comment ReviewNB#9 (comment) this fixes following shortcomings: * Linting violation for overly broad exception * Additional whitespace before starting the traceback * Showing treon's traceback despite that only the traceback within the cell is relevant
f4lco
added a commit
to f4lco/treon
that referenced
this pull request
Jun 28, 2019
In reference to PR comment ReviewNB#9 (comment) this fixes following shortcomings: * Linting violation for overly broad exception * Additional whitespace before starting the traceback * Showing treon's traceback despite that only the traceback within the cell is relevant
f4lco
added a commit
to f4lco/treon
that referenced
this pull request
Jun 30, 2019
In reference to PR comment ReviewNB#9 (comment) this fixes following shortcomings: * Linting violation for overly broad exception * Additional whitespace before starting the traceback * Showing treon's traceback despite that only the traceback within the cell is relevant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up Pylint with exception of the missing docstring rule. I added the promised
requirements-dev.txt, as well as basic CI integration and badge. I suppose you need to go to http://travis-ci.org and flip the toggle to enable Travis for treon.