Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the timeout. #282

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

unverbraucht
Copy link
Contributor

Together with the PR to ftp-deploy (SamKirkland/ftp-deploy#23) this allows setting the timeout for dealing with slow FTP servers.

Thanks for the great library!

Copy link

@JaviRpo JaviRpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should modify also the Readme explaining the new attribute

Copy link
Owner

@SamKirkland SamKirkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I'll make a followup PR to upgrade the npm package and add to readme

@SamKirkland SamKirkland merged commit 01dea7c into SamKirkland:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants