fix: trigger onViewableItemsChanged when data changes #1259
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
|
We are experiencing the same issue as described in this PR and, when applying these changes by @intergalacticspacehighway, it seems to resolve it for us. @naqvitalha Are there any plans to merge this and release this properly? |
|
any update? |
|
any updates on this? |
|
Common guys, please just merge this already! 8th of July! |
|
@naqvitalha please, merge some of these quality PRs and cut a release. We're playing cat & mouse with patching |
|
any update? |
|
will this work now?.Any comments? |
|
@favazpa we gave up with FlashList and are using Legendlist now. It's also up so 20% faster in our tests and has proper support. https://github.com/LegendApp/legend-list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FlashList does not re-trigger
onViewableItemsChangedcallback if the data prop changes. This also varies from React Native's FlatList. The function nameonViewableItemsChangedis such that it should trigger if data changes (because it can change the visible items). React Native'sVirtualizedListuses a similar approach used in this PR to re-trigger the viewability state in didUpdate.Fixes (issue #)
#566
Reviewers’ hat-rack 🎩
onViewableItemsChangedfires when data prop changes.Screenshots or videos (if needed)
Checklist