Pass extraData to stickyOverrideRowRenderer
#1310
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaders In our usage of FlashList we have a "selected" checkbox on the sticky header of each group. When these rows are stuck to the top, they don't update when `extraData` changes. When they come unstuck from the top, they update immediately. Regular header rows are updated when `extraData` changes, but these for some reason aren't. We've been testing this locally and it works nicely. I don't know whether there's a specific reason that `extraData` is not included in sticky row renderers, but it seems reasonable that rows should behave the same way when they're stuck as they do when they're not stuck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (issue #1152)
In our usage of FlashList, we have a "selected" checkbox on the sticky header of each group. This header item allows the user to select all items in the group. However, when using sticky headers, selecting the group doesn't update the header row.
When these rows are stuck to the top, they don't update when
extraDatachanges. When they come unstuck from the top, they update immediately. Regular header rows are updated whenextraDatachanges, but these for some reason aren't.We've been testing this locally and it works nicely. I don't know whether there's a specific reason that
extraDatais not included in sticky row renderers, but it seems reasonable that rows should behave the same way when they're stuck as they do when they're not stuck.Reviewers’ hat-rack 🎩
stickyHeaderIndexesScreenshots or videos (if needed)
This happened on a work application, so I probably shouldn't share screen recordings of the issue. I can create a sample application if it's absolutely needed, but this change is pretty simple and I don't know whether it's required.
Checklist