-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: inverted
option causing sticky headers, ListEmptyComponent to appear inverted, and causing scroll direction to be inverted on web
#1487
base: main
Are you sure you want to change the base?
Conversation
I have signed the CLA! |
… `horizontal` is set
Oh sorry I just patched files that already has been built(js files only) and it works. |
Hi, this patch fixed the inverted scroll in Web. But created a different issue. if there is any item with scrollable content, the scroll behaviour will break. You can check this behaviour by rendering any item as scrollable. Verified with and without the patch. Without the patch, scrollable item is working as expected. But overall scroll behaviour is reveresed. With the patch, overall scroll behaviour is fixed. But scrollable item is broken.. |
Thanks @aicopdev , I fixed it by checking event target for scrollability using getComputedStyles and letting those nested elements handle wheel events if they are scrollable. |
Thanks @mtourj Can you please update the patch file with this changes ?? Does it work with the latest changes also ?? Not able to do so by just changing based on the PR and last patch file. I mean, I tried applying the patch for components based on the PR. But vertical scroll behaviour stopped working. Have you verified scrolls in both directions ?? |
Description
This fixes three problems that occur when
inverted
is enabled on FlashList:Tested in the expo fixture as well as in my own application.
Resolves #1511 #1351 #1177 #611
Checklist