Fix crash if estimatedItemSize is NaN #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (issue #)
This PR fixes a crash caused by the estimatedItemSize having a NaN value in some cases. (I came across with the problem when I was developing a Carousel component where I was calculating the estimatedItemSize inside of a useCallback.) The application now checks for NaN values and sets estimatedItemSize to null, which prevents the crash. However, this may cause performance issues, so a warning message is displayed in the console to alert developers about the potential problem.
Screenshots or videos (if needed)
Checklist
Fixed
-estimatedItemSize is NaN check