Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android RN 0.73 Support - Update build.gradle w/ Namespace #879

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Android RN 0.73 Support - Update build.gradle w/ Namespace #879

wants to merge 2 commits into from

Conversation

alexhernandez
Copy link

@efstathiosntonas
Copy link
Contributor

Hey @alexhernandez can you please change the PR title to 0.73 instead of 0.72? Thanks

@alexhernandez alexhernandez changed the title Android RN 72 Support - Update build.gradle w/ Namespace Android RN 73 Support - Update build.gradle w/ Namespace Jul 21, 2023
@alexhernandez
Copy link
Author

@efstathiosntonas updated

@alexhernandez alexhernandez changed the title Android RN 73 Support - Update build.gradle w/ Namespace Android RN 0.73 Support - Update build.gradle w/ Namespace Jul 21, 2023
@alexhernandez
Copy link
Author

@efstathiosntonas let me know if there is anything else I need to update on this MR 👍

@gabrieldonadel
Copy link

Any plans on merging this now that react-native 0.73 RC1 is out?

@frankcalise
Copy link

@alexhernandez have you accepted the CLA?

@Titozzz
Copy link

Titozzz commented Oct 10, 2023 •
edited
Loading

A cleaner fix exists that also removes the user facing warning because it create a new separate manifest:
See https://github.com/react-native-webview/react-native-webview/pull/3174/files

@naqvitalha
Copy link
Collaborator

@alexhernandez Can you accept the CLA so this can be merged?

@gasolin gasolin mentioned this pull request May 28, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexhernandez @efstathiosntonas @gabrieldonadel @frankcalise @Titozzz @naqvitalha