Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Fix CSS Syntax Errors in VSCode for Liquid in CSS #24

Open
mzachdev opened this issue Mar 31, 2023 · 2 comments
Open

[Feature]: Fix CSS Syntax Errors in VSCode for Liquid in CSS #24

mzachdev opened this issue Mar 31, 2023 · 2 comments

Comments

@mzachdev
Copy link

What area(s) will this request affect?

Theme

What type of change do you want to see?

New feature

Overview

I'm unsure if this feature should be added to Shopify CLI or some other part of Shopify theme development, but hopefully this is a good place to start.

I want the Shopify-CLI integration to manage all parts of Liquid coding, including Liquid in CSS and Liquid in JS. There should be no syntax errors displaying from VSCode (unless there really is an error in the syntax). The Shopify CLI should somehow override the default VSCode behaviour for all files with a .liquid extension.

Obviously I still want the language mode to be CSS for a .css.liquid file, for correct syntax highlighting, but there shouldn't be errors showing up which affect the syntax highlighting.

Motivation

When I am working with a .css.liquid file in VSCode, the curly braces that wrap the Liquid (e.g. {{ settings.color_large_image_bg | default: "#1c1d1d" }}) causes VSCode to underline some parts of the CSS in red, and shows errors in the syntax.

css-syntax-errors-for-liquid-in-css

@alvaro-shopify
Copy link

Hi @mzachdev . Thanks for your proposal!. Let me ping @Shopify/theme-developer-tools so they can evaluate better this enhancement

@karreiro karreiro transferred this issue from Shopify/cli Apr 20, 2023
@karreiro
Copy link
Contributor

Hey @mzachdev, thanks for bringing up this issue! I've transferred it over here because the main motivation is related to Liquid highlighting features. Hopefully, we may get this enhancement sorted out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants