added free form text pattern to use with example content #36
Conversation
| - include: '#javascript_codefence' | ||
| - include: '#object' | ||
| - include: '#tag' | ||
| - include: '#free_form_text' |
There was a problem hiding this comment.
one of the patterns that came with #core was the doc tag so I removed it so we didn't have any potential nested rule action.
Manually adding patterns also let us set the free_form_text above text.basic.html allowing us to properly highlight free form text anywhere within the example content.
There was a problem hiding this comment.
Since our hover in theme-tools assumes it's entirely liquid, how does it appear there?
There was a problem hiding this comment.
It looks like this
Essentially the free form text is picked up as if you were writing plain text.
|
|
||
| liquid_doc_fallback_tag: | ||
| match: '(@\w+)\b' | ||
| captures: | ||
| 1: { name: comment.block.liquid } | ||
|
|
||
| free_form_text: | ||
| match: '(?:(?![{<]).)+' |
There was a problem hiding this comment.
I think this might capture too much. The second @example is being treated as part of the first example.
The current approach might be enough to handle free-form text. We don't even know if it's a feature we need. I'd keep this as draft for now or close it.
Closes: https://github.com/Shopify/developer-tools-team/issues/614
Adds proper highlighting for free form text pattern for
@examplethat aligns with@descriptionand@paramtagsBefore:
After:
