Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support for literals #1927

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Introduce support for literals #1927

merged 2 commits into from
Mar 6, 2025

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Mar 6, 2025

Changes applied by this PR:

* Introduce support for literal comparisons (e.g., `{{ 'hello' == 'hello' }}`)
* Evaluate expressions as truthy/falsy to unlock scenarios, such as `<div class="{{ disabled and "modal--disabled" }}">`
* Add additional scenarios to the expression test suite
* Simplify `LogicalExpression` implementation

@karreiro
* Introduce support for literal comparisons (e.g., `{{ 'hello' == 'he…
374848c 
…llo' }}`)

* Evaluate expressions as truthy/falsy to unlock scenarios, such as `<div class="{{ disabled and "modal--disabled" }}">`
* Add additional scenarios to the expression test suite
* Simplify `LogicalExpression`
@karreiro karreiro requested a review from albchu March 6, 2025 11:19
@karreiro karreiro merged commit 53b95b6 into better-bools-than-ghouls Mar 6, 2025
23 checks passed
@albchu albchu deleted the better-bools-than-ghouls-updates branch March 6, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albchu albchu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@karreiro