Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button's success tone prop is not working for icons #13172

Open
aeperea opened this issue Feb 5, 2025 · 0 comments
Open

Button's success tone prop is not working for icons #13172

aeperea opened this issue Feb 5, 2025 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@aeperea
Copy link
Contributor

aeperea commented Feb 5, 2025

Summary

When setting up an button icon with plain variant, the tone for success is not being visible in the icon.

        <Button variant="plain" tone="success" icon={PlusIcon} />

Codesandbox example

Expected behavior

The tone prop should pass to the icon as well. This works with no issues for the critical tone.

Actual behavior

Wrap animated gifs/videos in a details tag:

Summary of your gif(s) Description of what the gif shows

Steps to reproduce

Link to sandbox

  1. Add a Button with plain variant and tone success
  2. Set up any Icon
  3. See the results

Are you using React components?

None

Polaris version number

No response

Browser

No response

Device

No response

@aeperea aeperea added Bug Something is broken and not working as intended in the system. untriaged labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant