Improve typing of Stripe::ApiResource#metadata
#307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Changes
Per the docs, metadata values are always strings (there is no nesting). I opted to not change the signature of
#metadata=
because you can technically pass in non-strings to the method and either the values will be stringified (e.g.1
becomes"1"
) or the keys ignored (e.g. a key with anil
value).Technically, you could have junk in there until you refresh the data, but I'm not sure supporting that is desirable?
stripe