Fix RBI -> RBS translation for generics #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
paracycle
reviewed
Mar 6, 2025
lib/rbi/rbs/type_translator.rb
Outdated
Comment on lines
155
to
176
| case type_name | ||
| when "Array" | ||
| "T::Array" | ||
| when "Class" | ||
| "T::Class" | ||
| when "Enumerable" | ||
| "T::Enumerable" | ||
| when "Enumerator" | ||
| "T::Enumerator" | ||
| when "Hash" | ||
| "T::Hash" | ||
| when "Set" | ||
| "T::Set" | ||
| when "Range" | ||
| "T::Range" | ||
| else | ||
| type_name | ||
| end |
There was a problem hiding this comment.
I think we are missing T::Enumerator::Chain and T::Enumerator::Lazy here: https://github.com/sorbet/sorbet/blob/master/rbi/sorbet/t.rbi#L323-L376
There was a problem hiding this comment.
Also, what if the name was fully qualified, like ::Array[String]?
KaanOzkan
reviewed
Mar 6, 2025
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-fix-rbs-generic
branch
from
843e550 to
d672b0b
Compare
KaanOzkan
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes in there:
Foo[A, B]is not just translated asFooArraytoT::Arrayand friends