Skip to content

Commit b9a2345

Browse files
authoredMar 4, 2025
feat(): React 19/ RN 0.78 upgrade (#2993)
BREAKING CHANGE: * React 19 and React Native 0.78 minimum are required * SDK 26 minimum is required on Android * The `debug` and `mode` properties are now deprecated * `SKSGRoot` api is now async, as a result functions such as `drawAsImage` are now async as well.
1 parent 673e21e commit b9a2345

File tree

130 files changed

+2383
-7298
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

130 files changed

+2383
-7298
lines changed
 

‎.github/workflows/ci.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
pull_request:
77
branches:
88
- main
9+
- next
910
merge_group:
1011
types:
1112
- checks_requested
@@ -190,15 +191,14 @@ jobs:
190191
- name: Install Android SDK
191192
run: |
192193
echo "sdk.dir=$ANDROID_HOME" > $GITHUB_WORKSPACE/apps/paper/android/local.properties
193-
echo "sdk.dir=$ANDROID_HOME" > $GITHUB_WORKSPACE/apps/fabric/android/local.properties
194194
195195
- name: Cache Gradle
196196
uses: actions/cache@v3
197197
with:
198198
path: |
199199
~/.gradle/wrapper
200200
~/.gradle/caches
201-
key: ${{ runner.os }}-gradle-${{ hashFiles('./apps/paper/android/gradle/wrapper/gradle-wrapper.properties') }}-${{ hashFiles('./apps/fabric/android/gradle/wrapper/gradle-wrapper.properties') }}
201+
key: ${{ runner.os }}-gradle-${{ hashFiles('./apps/paper/android/gradle/wrapper/gradle-wrapper.properties') }}
202202
restore-keys: |
203203
${{ runner.os }}-gradle-
204204
@@ -272,7 +272,7 @@ jobs:
272272
# run: echo "PACKAGE_NAME=${{ env.PACKAGE_NAME }}" >> $GITHUB_ENV
273273
- name: Launch APK
274274
env:
275-
PACKAGE_NAME: ${{ matrix.working-directory == 'fabricexample' && 'com.fabricexample' || 'com.paper' }}
275+
PACKAGE_NAME: 'com.paper'
276276
run: adb shell monkey -p ${{ env.PACKAGE_NAME }} 1
277277

278278
# On fabric, the system fonts are slightly different

‎apps/docs/docs/shapes/atlas.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ rsxForm = Skia.RSXformFromRadians(1, r, 100, 0, 125, 25);
4747
In the example below, we draw in simple rectangle as an image.
4848
Then we display that rectangle 150 times with a simple transformation applied to each rectangle.
4949

50-
```tsx twoslash
50+
```tsx
5151
import {Skia, drawAsImage, Group, Rect, Canvas, Atlas, rect} from "@shopify/react-native-skia";
5252

5353
const size = { width: 25, height: 11.25 };
@@ -56,7 +56,7 @@ const imageSize = {
5656
width: size.width + strokeWidth,
5757
height: size.height + strokeWidth,
5858
};
59-
const image = drawAsImage(
59+
const image = await drawAsImage(
6060
<Group>
6161
<Rect
6262
rect={rect(strokeWidth / 2, strokeWidth / 2, size.width, size.height)}

0 commit comments

Comments
 (0)
Failed to load comments.