Making first frame render synchronous #2989
Conversation
|
I have signed the CLA! |
|
looks very nice :) |
…-native-skia into bugfix-blank-first-frame
| @@ -76,7 +76,12 @@ export const Canvas = forwardRef( | |||
| }, []); | |||
|
|
|||
| // Root | |||
| const root = useMemo(() => new SkiaSGRoot(Skia, nativeId), [nativeId]); | |||
| const root = useMemo(() => { | |||
There was a problem hiding this comment.
I'm surprised this change helps, do you have examples I can try where I could see a difference there?
There was a problem hiding this comment.
Funnily enough, removing either set of changes (this one or the synchronous presentation) makes the bug return (i.e. the first frame renders empty).
There was a problem hiding this comment.
Happy to provide an example, but not sure what would be the best form? Ideally I would prepare a unit test demonstrating the issue, but I didn't find a suitable example to start off with – I would need to render a component, preferrably with frame-by-frame control, would appreciate hints on how to do it.
|
Could you provide me some small examples that would help me experience the issue described in #2968? This would allow me to review this more easily but overall this looks very good 👍 |
Sure thing. The snack (https://snack.expo.dev/@anton9001/react-native-skia-error-app) in the original issue is a one-component example that exhibits the problem; I can as well create a separate branch in my fork to demonstrate that if that's easier? Lmk what's the easiest for you. |
This PR aims to address the issue described in #2968.
Summary of changes
<Canvas />component populatesSkiaSGRootinstance with the children elements so that it has content from the get-go instead of letting the first render to come through and appending children in an effectWindowContextspresent()method has been extended with a booleanflushargument instructing the context to render the image immediately (i.e. perform a synchronous presentation)flushargument into account.Disclaimer: I am by no means an expert in the inner workings of Skia's renderers and did the change using (my very own) common sense and testing locally; happy to adhere to changes to provide a better implementation, shall there be an oversight in this changeset.