Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds breaking web code for example #3000

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

agustinferrari
Copy link

After #2998, most of the web animation issues seem to be fixed, but there is still this weird case where if you convine a shared value + reaction + callback that sets state, then the animation does not run.

Also noticed that I'm getting this error even when the animation runs (without the new code):

Uncaught TypeError: Cannot read properties of undefined (reading 'setPicture')
    at Object.setJsiProperty (NativeSkiaModule.web.ts:20:33)
    at shopify_ContainerTs1 (Container.ts:28:15)
    at shopify_ContainerTs4 (Container.ts:119:7)
    at threads.js:115:13
    at Array.forEach (<anonymous>)
    at reactNativeReanimated_threadsJs5 (threads.js:114:17)

This animation works correctly on iOS and also works correctly with v1.7.6

@agustinferrari agustinferrari mentioned this pull request Mar 5, 2025
1 task
@codeion
Copy link

codeion commented Mar 5, 2025

After #2998, most of the web animation issues seem to be fixed, but there is still this weird case where if you convine a shared value + reaction + callback that sets state, then the animation does not run.

Also noticed that I'm getting this error even when the animation runs (without the new code):

Uncaught TypeError: Cannot read properties of undefined (reading 'setPicture')
    at Object.setJsiProperty (NativeSkiaModule.web.ts:20:33)
    at shopify_ContainerTs1 (Container.ts:28:15)
    at shopify_ContainerTs4 (Container.ts:119:7)
    at threads.js:115:13
    at Array.forEach (<anonymous>)
    at reactNativeReanimated_threadsJs5 (threads.js:114:17)

This animation works correctly on iOS and also works correctly with v1.7.6

This error was introduced in v1.11.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants