Test server.rb with better isolation
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/test-server-with-better-isolation
branch
from
660d94d to
76fe8ad
Compare
andyw8
commented
Mar 4, 2025
vinistock
reviewed
Mar 4, 2025
|
(test failures against Rails main, see #586) |
andyw8
force-pushed
the
andyw8/test-server-with-better-isolation
branch
from
3bd7bae to
aa08c1e
Compare
vinistock
approved these changes
Mar 5, 2025
andyw8
force-pushed
the
andyw8/test-server-with-better-isolation
branch
from
aa08c1e to
4aa87d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
server.rbruns within the host Rails application, we should ensure we don't accidentally introduce something which depends on sorbet-runtime.