Fix tests for Rails main due to changes relating to default column value #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/fix-for-rails-main
branch
3 times, most recently
from
42a65d6 to
5402089
Compare
andyw8
changed the title
andyw8
force-pushed
the
andyw8/fix-for-rails-main
branch
from
5402089 to
77e47b3
Compare
andyw8
commented
Mar 6, 2025
| ] | ||
| else | ||
| [ | ||
| ["id", "integer", nil, false], |
There was a problem hiding this comment.
There's some duplication but I think it's easier to follow this way.
andyw8
changed the title
|
Can you please explain what changed? There's no PR description and I'm confused as to why the default for an integer column would now be a string. Also, is that the only default that changed? |
|
I had a comment in source, I've copied to the description.
Other way around. It's a string currently, the change in Rails makes it an integer. |
vinistock
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default values behavior changed in rails/rails#54683