Include thread-safety rubocop

Author: alexpark20

Gemfile.lock

@@ -3,6 +3,7 @@ PATH
   specs:
     rubocop-shopify (2.15.1)
       rubocop (~> 1.62)
+      rubocop-thread_safety
 
 GEM
   remote: https://rubygems.org/
@@ -44,6 +45,9 @@ GEM
       unicode-display_width (>= 2.4.0, < 4.0)
     rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
+    rubocop-thread_safety (0.7.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     ruby-progressbar (1.13.0)
     unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)

bin/sort-cops

@@ -58,7 +58,7 @@ def sort_cops(file_path)
 end
 
 if ARGV.empty?
-  puts "Usage: ruby sort_cops.rb path/to/rubocop.yml"
+  puts "Usage: ruby sort-cops path/to/rubocop.yml"
   exit 1
 end
 

rubocop-shopify.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 3.1.0"
 
   s.add_dependency("rubocop", "~> 1.62")
+  s.add_dependency("rubocop-thread_safety")
 end

rubocop.yml

@@ -9,6 +9,8 @@ inherit_mode:
   - Exclude
   - Include
 
+plugins: rubocop-thread_safety
+
 AllCops:
   StyleGuideBaseURL: https://shopify.github.io/ruby-style-guide/
   NewCops: disable # New cops will be triaged by style guide maintainers instead.
@@ -1165,7 +1167,7 @@ Style/MultipleComparison:
   Enabled: false
 
 Style/MutableConstant:
-  Enabled: false
+  Enabled: true
 
 Style/NegatedIf:
   Enabled: false
@@ -1549,3 +1551,8 @@ Style/YodaCondition:
 
 Style/ZeroLengthPredicate:
   Enabled: false
+
+<% if rubocop_version >= "1.71" %>
+ThreadSafety:
+  Enabled: true
+<% end %>

test/fixtures/full_config.yml

@@ -3526,7 +3526,7 @@ Style/MultipleComparison:
   ComparisonsThreshold: 2
 Style/MutableConstant:
   Description: Do not assign mutable objects to constants.
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.34'
   VersionChanged: '1.8'
   SafeAutoCorrect: false
@@ -4523,7 +4523,41 @@ Style/ZeroLengthPredicate:
   Safe: false
   VersionAdded: '0.37'
   VersionChanged: '0.39'
+ThreadSafety/ClassAndModuleAttributes:
+  Description: Avoid mutating class and module attributes.
+  Enabled: true
+  ActiveSupportClassAttributeAllowed: false
+ThreadSafety/InstanceVariableInClassMethod:
+  Description: Avoid using instance variables in class methods.
+  Enabled: true
+ThreadSafety/MutableClassInstanceVariable:
+  Description: Do not assign mutable objects to class instance variables.
+  Enabled: true
+  EnforcedStyle: literals
+  SafeAutoCorrect: false
+  SupportedStyles:
+  - literals
+  - strict
+ThreadSafety/NewThread:
+  Description: Avoid starting new threads. Let a framework like Sidekiq handle the
+    threads.
+  Enabled: true
+ThreadSafety/DirChdir:
+  Description: Avoid using `Dir.chdir` due to its process-wide effect.
+  Enabled: true
+  AllowCallWithBlock: false
+ThreadSafety/RackMiddlewareInstanceVariable:
+  Description: Avoid instance variables in Rack middleware.
+  Enabled: true
+  Include:
+  - app/middleware/**/*.rb
+  - lib/middleware/**/*.rb
+  - app/middlewares/**/*.rb
+  - lib/middlewares/**/*.rb
+  AllowedIdentifiers: []
 inherit_mode:
   merge:
   - Exclude
   - Include
+ThreadSafety:
+  Enabled: true