Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YJIT: Skip adding past_page_bytes for past pages #8433

Merged
merged 1 commit into from
Sep 13, 2023
Merged

YJIT: Skip adding past_page_bytes for past pages #8433

merged 1 commit into from
Sep 13, 2023
+22 −2

Conversation

k0kubun
Copy link
Member

@k0kubun k0kubun commented Sep 13, 2023 •
edited
Loading

Fix Shopify#534

Currently, past_page_bytes is updated whenever CodeBlock changes its code page. However, when it moves from a past page to the next page, the bytes written in the page should have been already added to past_page_bytes. So this PR skips updating past_page_bytes when moving from a past page.

@matzbot matzbot requested a review from a team September 13, 2023 19:34
@k0kubun k0kubun changed the title YJIT: Skip adding past_pages_bytes for past pages YJIT: Skip adding past_page_bytes for past pages Sep 13, 2023
maximecb
maximecb approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@maximecb maximecb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the new test 🙏 :)

@maximecb maximecb merged commit b49be2a into ruby:master Sep 13, 2023
@maximecb maximecb deleted the yjit-fix-bytes branch September 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

YJIT: incorrect code size accounting?
2 participants
@k0kubun @maximecb