Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use posix spawn #551

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Prev Previous commit
Next Next commit
posix_spawn: handle pgroup
  • Loading branch information
byroot committed Jan 24, 2024
commit aad399e231f54f5447a8b32f9b6e0e7807b62580
19 changes: 17 additions & 2 deletions process.c
Original file line number Diff line number Diff line change
@@ -4659,7 +4659,22 @@ rb_posix_spawn(struct rb_execarg *eargp)
VALUE envp_str = eargp->envp_str;
char **envp = RTEST(envp_str) ? RB_IMEMO_TMPBUF_PTR(envp_str) : NULL;

int err = posix_spawn(&pid, abspath, NULL, NULL, argv, envp);
int err;

posix_spawnattr_t attr;
posix_spawnattr_init(&attr);

if (eargp->pgroup_given) {
if ((err = posix_spawnattr_setflags(&attr, POSIX_SPAWN_SETPGROUP))) {
rb_syserr_fail(err, "posix_spawnattr_setflags");
}

if ((err = posix_spawnattr_setpgroup(&attr, eargp->pgroup_pgid))) {
rb_syserr_fail(err, "posix_spawnattr_setpgroup");
}
}

err = posix_spawn(&pid, abspath, NULL, &attr, argv, envp);
if (err) {
rb_sys_fail(abspath);
}
@@ -4682,7 +4697,7 @@ rb_spawn_process(struct rb_execarg *eargp, char *errmsg, size_t errmsg_buflen)

#if HAVE_POSIX_SPAWN
if (//!eargp->use_shell &&
!eargp->pgroup_given &&
// !eargp->pgroup_given &&
!eargp->umask_given &&
!eargp->unsetenv_others_given &&
!eargp->close_others_given &&