Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shopify local app development #2182

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

alexanderMontague
Copy link
Contributor

@alexanderMontague alexanderMontague commented Mar 5, 2025

WHY are these changes introduced?

  • currently local app development is broken for Shopify internal developers, as we can not render embedded apps running locally within the shopify admin
  • With the transition to World, this adds the new local domains the local admin is using to the various places that need it within the app libraries
  • Do we also need to support the ruby libraries for local dev?

WHAT is this pull request doing?

  • add the necessary domains like we did for spin

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
  • I have added/updated tests for this change
  • I have documented new APIs/updated the documentation for modified APIs (for public APIs)

@alexanderMontague alexanderMontague marked this pull request as ready for review March 6, 2025 16:24
@alexanderMontague alexanderMontague requested a review from a team as a code owner March 6, 2025 16:24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if the compatibility helpers were needed at all but saw the spin ones and they were easy enough, so added for now

Update shop validators

add local dev admin domains to tests
@alexanderMontague alexanderMontague merged commit 6e9102f into main Mar 7, 2025
6 checks passed
@alexanderMontague alexanderMontague deleted the shauns/local-dev branch March 7, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants