Use Shopify/rbs's latest C parser implementation
#426
Closed
+356
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
use-c-api-rbs
branch
from
f021d4e to
046e975
Compare
st0012
commented
Feb 27, 2025
paracycle
reviewed
Feb 27, 2025
st0012
force-pushed
the
use-c-api-rbs
branch
4 times, most recently
from
50ab3a7 to
e82cee7
Compare
amomchilov
approved these changes
Mar 4, 2025
amomchilov
approved these changes
Mar 4, 2025
Comment on lines
-110
to
+124
| rbs_constant_t *constant = rbs_constant_pool_id_to_constant(fake_constant_pool, node->name->constant_id); | ||
| string_view str(constant->start, constant->length); | ||
| auto str = parser.resolveConstant(node->name); |
Morriar
reviewed
Mar 4, 2025
Morriar
reviewed
Mar 4, 2025
st0012
force-pushed
the
use-c-api-rbs
branch
2 times, most recently
from
5bdbdcd to
47e7d0d
Compare
amomchilov
approved these changes
Mar 5, 2025
st0012
force-pushed
the
use-c-api-rbs
branch
2 times, most recently
from
ed2dc23 to
e6a5c3a
Compare
- Create SignatureTranslator to simplify the translation of RBS signatures - Make TypeTranslator and MethodTypeTranslator store parser state - Remove RBSParser
The global constant pool is initialized at process startup and freed at process exit. With this change, we don't need to manually manage them in realmain.cc and pipeline_test_runner.cc. Co-authored-by: Alexander Momchilov <alexander.momchilov@shopify.com>
|
This has been upstreamed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adopts the latest RBS parser implementation from
Shopify/rbswith a major refactor.Some key changes:
realmainmodule and the beginning of the testing pipelineSignatureTranslatornow performs both RBS parsing + translation in itstranslateTypeandtranslateSignaturefunctionsrbs::Typeandrbs::MethodTypestructs become redundant as we don't need an intermediate data typeTypeTranslatorandMethodTypeTranslatornow store states like context and constant pool to reduce the number of parameters its functions need to keep passing downBefore
graph TD RBSSignaturesWalk -->|passes Comment| RBSParser RBSParser -->|returns MethodType or Type| RBSSignaturesWalk RBSParser -->|returns ParseError| RBSSignaturesWalk RBSSignaturesWalk -->|passes MethodType or Type| MethodTypeTranslator MethodTypeTranslator -->|uses Type| TypeTranslator subgraph Structs Comment ParseError MethodType Type end RBSSignaturesWalk --> Comment RBSParser --> Comment RBSParser --> ParseError RBSParser --> MethodType RBSParser --> Type MethodTypeTranslator --> MethodType MethodTypeTranslator --> Type TypeTranslator --> TypeAfter
graph TD RBSSignaturesWalk -->|creates| Comment RBSSignaturesWalk -->|passes Comment| SignatureTranslator SignatureTranslator -->|creates| Parser SignatureTranslator -->|uses| Comment SignatureTranslator -->|calls parseMethodType| Parser SignatureTranslator -->|calls parseType| Parser SignatureTranslator -->|passes Parser| MethodTypeTranslator MethodTypeTranslator -->|passes Parser| TypeTranslator subgraph Structs Comment end RBSSignaturesWalk --> Comment SignatureTranslator --> CommentTest plan
See included automated tests.