Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use install path from global bundle config #384

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Jun 6, 2023

Rely on the environment variable $GEM_HOME. This has the side effect of making tests faster for people with a global bundle config set path 'vendor/bundle' since bundle won't have to download and install the same gems over and over again.

Fixes #239.

Fixes #239.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the bugfix Fix a bug label Jun 6, 2023
@Morriar Morriar requested a review from a team as a code owner June 6, 2023 19:34
@Morriar Morriar self-assigned this Jun 6, 2023
@Morriar Morriar requested review from st0012 and egiurleo June 6, 2023 19:34
@Morriar Morriar enabled auto-merge June 6, 2023 21:32
auto-merge was automatically disabled June 9, 2023 14:41

Base branch was modified

@Morriar Morriar merged commit f6729a6 into main Jun 9, 2023
@Morriar Morriar deleted the at-fix-context-bundle-path branch June 9, 2023 15:24
@shopify-shipit shopify-shipit bot temporarily deployed to production June 21, 2023 15:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies under vendor/ affect test output
3 participants