Do not list files ignored by Sorbet #383
Merged
+79
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
reviewed
Jun 6, 2023
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-fix-bump-ignore
branch
from
604748a to
4c6ddcd
Compare
paracycle
reviewed
Jun 6, 2023
paracycle
reviewed
Jun 6, 2023
Morriar
force-pushed
the
at-fix-bump-ignore
branch
from
4c6ddcd to
787773c
Compare
paracycle
reviewed
Jun 6, 2023
We ignore files matching the paths ignored in the `sorbet/config` and try to reproduce Sorbet behvior. From Sorbet docs on `--ignore`: > Ignores input files that contain the given string in their paths (relative to the input path passed to > Sorbet). Strings beginning with / match against the prefix of these relative paths; others are substring > matchs. Matches must be against whole folder and file names, so `foo` matches `/foo/bar.rb` and > `/bar/foo/baz.rb` but not `/foo.rb` or `/foo2/bar.rb`. To produce the same behavior, we match files using `File.fnmatch?` and we were prefixing and suffixing the paths with `**`. When the Sorbet config contains ignored files with extensions like this: ``` --ignore=foo.rb ``` This doesn't work as we are trying to match `foo.rb` with `**/foo.rb/**`. To fix this problem, we only append `**` to the ignored path IF it does contain a file extension. Fixes #379. Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Morriar
force-pushed
the
at-fix-bump-ignore
branch
from
787773c to
983c126
Compare
paracycle
approved these changes
Jun 6, 2023
rafaelfranca
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore files matching the paths ignored in the
sorbet/configand try to reproduce Sorbet behvior.From Sorbet docs on
--ignore:To produce the same behavior, we match files using
File.fnmatch?and we were prefixing and suffixing the paths with**.When the Sorbet config contains ignored files with extensions like this:
This doesn't work as we are trying to match
foo.rbwith**/foo.rb/**.To fix this problem, we only append
**to the ignored path IF it does contain a file extension.Fixes #379.