Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spoom files fails a runtime typecheck #400

Closed
searls opened this issue Jun 21, 2023 · 2 comments
Closed

spoom files fails a runtime typecheck #400

searls opened this issue Jun 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@searls
Copy link

searls commented Jun 21, 2023

Describe the bug
I'm trying to run $ bundle exec spoom files on ref 24b1c92ffb97b32f6ae79b2e0f53cc10a3cddb76 of testdouble/mocktail#22 and I get this:

bundler: failed to load command: spoom (/Users/justin/.rbenv/versions/3.2.2/bin/spoom)
/Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/abstract/declare.rb:40:in `block (2 levels) in declare_abstract': Spoom::Printer is declared as abstract; it cannot be instantiated (RuntimeError)
        from <internal:kernel>:90:in `tap'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/abstract/declare.rb:38:in `block in declare_abstract'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spoom-1.2.1/lib/spoom/file_tree.rb:242:in `initialize'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/methods/call_validation.rb:256:in `bind_call'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/methods/call_validation.rb:256:in `validate_call'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/methods/_methods.rb:275:in `block in _on_method_added'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/abstract/declare.rb:38:in `new'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/abstract/declare.rb:38:in `block in declare_abstract'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spoom-1.2.1/lib/spoom/file_tree.rb:89:in `print_with_strictnesses'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/methods/call_validation.rb:256:in `bind_call'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/methods/call_validation.rb:256:in `validate_call'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/sorbet-runtime-0.5.10884/lib/types/private/methods/_methods.rb:275:in `block in _on_method_added'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spoom-1.2.1/lib/spoom/cli.rb:54:in `files'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/thor-1.2.2/lib/thor/command.rb:27:in `run'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/thor-1.2.2/lib/thor/invocation.rb:127:in `invoke_command'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/thor-1.2.2/lib/thor.rb:392:in `dispatch'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/thor-1.2.2/lib/thor/base.rb:485:in `start'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spoom-1.2.1/exe/spoom:7:in `<top (required)>'
        from /Users/justin/.rbenv/versions/3.2.2/bin/spoom:25:in `load'
        from /Users/justin/.rbenv/versions/3.2.2/bin/spoom:25:in `<top (required)>'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/cli/exec.rb:58:in `load'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/cli/exec.rb:58:in `kernel_load'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/cli/exec.rb:23:in `run'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/cli.rb:484:in `exec'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/cli.rb:31:in `dispatch'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/cli.rb:25:in `start'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/exe/bundle:48:in `block in <top (required)>'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/lib/bundler/friendly_errors.rb:103:in `with_friendly_errors'
        from /Users/justin/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/bundler-2.3.6/exe/bundle:36:in `<top (required)>'
        from /Users/justin/.rbenv/versions/3.2.2/bin/bundle:25:in `load'
        from /Users/justin/.rbenv/versions/3.2.2/bin/bundle:25:in `<main>'

Versions to reproduce:

$ ruby -v
ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin22]
$ bundler -v
Bundler version 2.3.6
$ be spoom -v
Spoom v1.2.1
@searls searls added the bug Something isn't working label Jun 21, 2023
@Morriar
Copy link
Collaborator

Morriar commented Jun 21, 2023

👋 Hey Justin,

We actually already fixed this in ba6a42f but never released a new version of the gem...

I just pushed Spoom 1.2.2 which should solve your issue.

Feel free to reopen this if the problem persists.

@Morriar Morriar closed this as completed Jun 21, 2023
@searls
Copy link
Author

searls commented Jun 21, 2023

Thank you @Morriar, I appreciate it!

searls added a commit to testdouble/mocktail that referenced this issue Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants